Skip to content

setEqualizer doesn't work? #58

Description

@HelgeStenstrom

public void setEqualizer(final float[] array, final int stop) {
if (!isPausedOrPlaying() || !(audioInputStream instanceof PropertiesContainer))
return;
// Map<?, ?> map = ((PropertiesContainer) audioInputStream).properties()
final float[] equalizer = (float[]) ((PropertiesContainer) audioInputStream).properties().get("mp3.equalizer");
if (stop >= 0) System.arraycopy(array, 0, equalizer, 0, stop);
}

I can't see that this method has any side effect, desired or not. It copies an array passed to it, into a local variable, and when the method goes out of scope, the copy is lost.

What is the intention with the method? If it never has worked as intended, maybe it should be removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions