Repository navigation
Avoid duplicating errors for ignored batch values - #100
Merged
inhere merged 1 commit intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FireBatchdocuments unsupported inputs as ignored, but a nil or other non-event value after a failed event appends that event's error again. A batch with two actual failures can return four errors.Keep the temporary error inside each iteration. Real event errors retain their order and identity, and ignored values no longer duplicate an earlier failure.
Go 1.26.0 / macOS arm64 validation:
The full race run still fails four existing async/shared-data tests, all reproduced on the pristine base. Those failures are not suppressed or changed here. Hosted Linux/Go CI remains unverified locally.