Conversation
🦋 Changeset detectedLatest commit: 2487eb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows release should start without requiring users to install the Visual C++ Redistributable separately.
What changed
Enable Rust's
crt-statictarget feature only for Windows MSVC builds. Other targets keep their existing linker behavior.Testing
cargo fmt --all -- --checkcargo test --locked --workspacecargo xwin build --release --target x86_64-pc-windows-msvc --lockedobjdump -p gws.exeshows only Windows system DLL imports, with noVCRUNTIME*,MSVCP*,api-ms-win-crt-*, orucrtbase.dlldependency