Repository navigation
Open three category panels from Start script tagging - #74
Merged
Merged
Conversation
The dialog now takes one script and one category, both single selects. OK adds the placeholders and replaces the panels with three views of the category: the new placeholders for the script sorted by score, every tagging for the script sorted by family, and every tagging sorted by score. Category panels can be opened with a preset sort, script filter and placeholders-only state.
New src/pangrams.ts holds a sample per script, keyed by the subset names in the family metadata: a pangram where a known one exists, else the first line of the Universal Declaration of Human Rights. OK in the dialog puts the Latin pangram and the chosen script's sample into the sample text of all three panels, so every preview shows both. Category panels can be opened with a preset sample text.
Latin plus one script is now four words at most, so previews stay short.
…ging That panel lists every family for the category, most without the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the Start script tagging dialog to the workflow agreed in today's meeting.
src/pangrams.ts, keyed by the subset names in the family metadata. 31 scripts are covered, including every script with more than five families. A script without a sample gets "Hello world" only.To support this, a category panel can be opened with a preset sort, script filter, placeholders-only state and sample text (
Panel.vue,TagsByCategories.vue). Existing panels are unchanged.Based on main.
Test plan
Checked on the scripts dev server with Arabic and
/Expressive/Loud:vue-tscclean apart from the pre-existing vue-select error.🤖 Generated with Claude Code