Repository navigation
Land the Start script tagging dialog and Placeholders only filter on main - #73
Merged
Merged
Conversation
One dialog sets up a tagger for a script. The tagger picks one script and keeps or edits a list of categories, prefilled with the Expressive and Quality tags. OK adds a 0-score placeholder for every family that supports the script and every chosen category, tagged for that script. Families with a wght axis get a variable placeholder at the wght extremes, crossed with the wdth extremes when the family has wdth. Every other family gets a static placeholder. A family that already has a tagging for the script and category is skipped, even at score 0, because a 0 means a person has looked at it. The dialog shows the counts before OK.
An all-scripts tagging already covers the script. The tagger reviews those on a second pass and uses Duplicate where the script needs its own scores, so the starter adds a placeholder only when the family has no tagging at all for the category.
A checkbox next to Variable only and Static only that shows only the placeholder taggings added in this session, so a tagger can work through them without the scored tags in between.
Add a Placeholders only filter to the categories view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands #71 and #72 on main. They were stacked on #70, and were merged into their base branches (
placeholder-scriptsandscript-starter) instead of main because those branches were not deleted after #70 merged. Main therefore has only #70, and the live/tagger/scripts/build has no Start script tagging button.This branch is
script-starter, which already holds both merged PRs, with main merged in. No new code.🤖 Generated with Claude Code