fix(gapic-common): ignore inherited Service constants in normalize_service

[linyiru]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
• Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running toys ci in the gem subdirectory.
• Update code documentation if necessary.

closes: #70

Summary

Gapic::LoggingConcerns.normalize_service looks up the Service constant with const_defined?'s default inherit: true. Generated REST stubs have no sibling Service, so the lookup walks up to Object. If the application defines a top-level ::Service, it is treated as a gRPC Service and service_name is called on it, raising NoMethodError during client construction.

gRPC transports are unaffected because they do define a local Service.

Change

Look up Service and Rest with inherit: false so only constants defined on the enclosing module are considered.

Tests

On starship (Ruby 3.4.10):

• toys test: 316 runs, 948 assertions, 0 failures, 0 errors
• bundle exec rubocop lib: 42 files, no offenses
• bundle exec ruby -Ilib:test test/gapic/logging_concerns_test.rb: 10 runs, 12 assertions, 0 failures

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[linyiru]

CLA is signed and green now.

The CI workflow run is sitting in action_required — as a first-time contributor from a fork, it needs a maintainer to click "Approve and run workflows" before anything starts. Could someone kick it off, and take a look when you get a chance?

Ran the suite locally in the meantime (Ruby 3.3.10, macOS):

• gapic-common tests: 316 runs, 948 assertions, 0 failures, 0 errors, 1 skip
• rubocop: 44 files inspected, no offenses

Happy to adjust anything.

[torreypayne]

@linyiru can you rebase on latest main? That should pull in the fix for the CI failures, then I can stamp

[linyiru]

@torreypayne thanks for reminding about this, I've just rebased and please let me know if any change needed.