Skip to content

impl(bigquery): add query errors#5873

Merged
alvarowolfx merged 3 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-query-err
Jun 11, 2026
Merged

impl(bigquery): add query errors#5873
alvarowolfx merged 3 commits into
googleapis:mainfrom
alvarowolfx:impl-bq-query-err

Conversation

@alvarowolfx

Copy link
Copy Markdown
Contributor

Towards #5844

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Jun 11, 2026
@alvarowolfx

Copy link
Copy Markdown
Contributor Author

Split from #5870

@alvarowolfx alvarowolfx marked this pull request as ready for review June 11, 2026 16:14
@alvarowolfx alvarowolfx requested a review from a team as a code owner June 11, 2026 16:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a custom QueryError enum using the thiserror crate to handle errors during BigQuery query operations, along with corresponding unit tests. The reviewer suggested adding the #[from] attribute to the Rpc error variant to automatically derive the From trait, enabling cleaner error propagation using the ? operator.

Comment thread src/bigquery/src/error.rs
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.88%. Comparing base (83e24b6) to head (592465f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5873      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files         229      230       +1     
  Lines       58080    58104      +24     
==========================================
+ Hits        56851    56873      +22     
- Misses       1229     1231       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/bigquery/src/error.rs
Comment thread src/bigquery/src/error.rs Outdated
Comment thread src/bigquery/src/error.rs Outdated
@alvarowolfx alvarowolfx merged commit 75137ab into googleapis:main Jun 11, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants