Repository navigation
Conversation
quirogas
added this pull request to stack #9722
October 23, 2026 23:55
quirogas
force-pushed
the
fix/windy-eagle-pubsub-auth-reuse
branch
from
October 23, 2026 23:56
c543d23 to
4a3617c
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the PubSub class to support reusing an existing GoogleAuth instance if provided in the options, and marks the keyFilename and credentials options as deprecated in the JSDoc. It also introduces logic to sync GAPIC JWT values on the cached credential when instantiating clients, ensuring existing properties are not overwritten. Corresponding unit tests have been added to verify these changes. There are no review comments, so I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse the PubSub GoogleAuth instance across underlying GAPIC clients and JSDocs.
Impact
Prevents duplicate GoogleAuth instantiations and duplicate credential deprecation warnings in PubSub.
Changes
this.options.authinPubSubconstructor if provided, and passthis.options.auth ??= this.authingetClientConfig()soPublisherClient,SubscriberClient, andSchemaServiceClientshare the sameGoogleAuthinstance.defaultServicePath,useJWTAccessWithScope,defaultScopes) ontothis.auth.cachedCredentialingetClientAsync_()andgetSchemaClient()whengetProjectId()has already cached aJWTclient prior to GAPIC client initialization.@deprecatednotices toClientConfigJSDoc propertieskeyFilenameandcredentialsinhandwritten/pubsub/src/pubsub.ts.Testing
handwritten/pubsub/test/pubsub.tsverifyingoptions.authreuse innew PubSub({auth})andgetClientAsync_().handwritten/pubsub/test/pubsub.tsverifying GAPIC JWT property synchronization onthis.auth.cachedCredentialingetClientAsync_()andgetSchemaClient().Alternatives
PubSubto create a separateGoogleAuthinstance per underlying GAPIC client causes duplicateGoogleAuthconstructor warnings whenkeyFilenameorcredentialsis passed and reloads credentials unnecessarily.