Repository navigation
ci: gate merge on CI completion and enable core package Node unit tests - #9719
Open
shivanee-p wants to merge 4 commits into
Open
shivanee-p wants to merge 4 commits into
shivanee-p wants to merge 4 commits into
Conversation
shivanee-p
marked this pull request as ready for review
October 23, 2026 21:46
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new GitHub composite action to wait for and verify CI workflow runs, and updates the conditional test runner script to run unit tests for core and dev-packages. The review feedback suggests improving the robustness of the new GitHub action by using optional chaining for the head SHA and wrapping API calls in a try-catch block to handle transient failures. Additionally, for the shell script, it is recommended to group conditional expressions inside double brackets to avoid spawning inefficient subshells.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gates PR merge on CI completion and enables core Node unit tests
Changes
.github/actions/wait-for-ci/action.yamlto wait for all PR workflows to finish and fail ifgenerator-testsfailsunits (22/24/26)inpresubmit.yamlandwindows-presubmit.yamlonwait-for-cion.pull_request.pathsingenerator-tests.yamlwithdorny/paths-filterand apresubmitstatus jobcore/packages/*andcore/dev-packages/*inci/run_conditional_tests.shci/run_conditional_tests.shselectscore/packages/gaxandcore/dev-packages/*forunits.