Skip to content

fix(gax): suppress cancel destroy error in StreamArrayParser and add Bun certification matrix #9652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danieljbruce wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix(gax): suppress cancel destroy error in StreamArrayParser and add Bun certification matrix #9652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9c946f
fix(gax): suppress cancel destroy error in StreamArrayParser and add …
danieljbruce Oct 16, 2026
7a9645d
[Independent review follow-ups]Restore proxy env vars and add StreamA…
danieljbruce Oct 16, 2026
064e880
[Independent review follow-ups] document why StreamArrayParser._destr…
danieljbruce Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions core/packages/gax/src/streamArrayParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,18 @@ export class StreamArrayParser extends Transform {
callback();
}

_destroy(err: Error | null, callback: (error?: Error | null) => void) {
// `_destroy` is now necessary because `cancel()` aborts `cancelSignal`,
// which aborts the underlying HTTP `response.body` stream with an
// `AbortError` that `stream.pipeline` forwards to `this.destroy(err)`.
// Before, the inherited `Transform._destroy` passed `err` directly to
// `callback(err)`, causing `StreamArrayParser` to emit a spurious `'error'`
// event even after an intentional `cancel()`. Now, it passes `null` when
// `this.cancelRequested` is true to suppress cancellation abort errors
// while still forwarding genuine errors when not cancelled.
callback(this.cancelRequested ? null : err);
}

Comment on lines +156 to +167

@danieljbruce danieljbruce Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Generated] Override StreamArrayParser._destroy(err, callback) (and document why _destroy is now necessary): when cancel() aborts cancelSignal, the underlying HTTP response.body stream aborts with an AbortError that stream.pipeline forwards into this.destroy(err). Previously, the inherited Transform._destroy passed err straight to callback(err), causing StreamArrayParser to emit a spurious 'error' event even after an intentional cancel(). Now, _destroy passes null when this.cancelRequested is true to suppress cancellation abort errors while still forwarding genuine errors when not cancelled.

cancel(): void {
this._done = true;
this.cancelRequested = true;
Expand Down
Loading
Loading