chore(spanner): executor framework instance admin actions implementation#8093
Open
alkatrivedi wants to merge 3 commits intomainfrom
Open
chore(spanner): executor framework instance admin actions implementation#8093alkatrivedi wants to merge 3 commits intomainfrom
alkatrivedi wants to merge 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements instance management functionality in the CloudClientExecutor, including update, delete, list, and get operations. Review feedback identifies a missing import for status, a logic error in the executeUpdateCloudInstance method where displayName was incorrectly assigned, and the hardcoding of nextPageToken which prevents proper pagination in executeListCloudInstances.
alkatrivedi
force-pushed
the
executor-framework-admin-actions
branch
2 times, most recently
from
9bba437 to
548f8d3
Compare
Contributor
Author
|
/gemini |
alkatrivedi
changed the title
alkatrivedi
force-pushed
the
executor-framework-admin-actions
branch
from
548f8d3 to
391ddc3
Compare
Comment on lines
+264
to
+268
| if (action.nodeCount !== undefined) { | ||
| instancePayload.nodeCount = action.nodeCount; | ||
| } | ||
| if (action.processingUnits !== undefined) { | ||
| instancePayload.processingUnits = action.processingUnits; |
Contributor
There was a problem hiding this comment.
There is no default value set for nodeCount or processingUnits , if none of it is provided. Also only one of these should be set
Comment on lines
+308
to
+309
| if (action.nodeCount !== undefined) paths.push('node_count'); | ||
| if (action.processingUnits !== undefined) paths.push('processing_units'); |
Contributor
There was a problem hiding this comment.
Follow the same approach for setting nodeCount and nodeCount as used in createInstance method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the implementation for instance admin actions: