Skip to content

Resolve unused variable warnings - #16576

Open
pefoley2 wants to merge 1 commit into
googleapis:mainfrom
pefoley2:main
Open

pefoley2 wants to merge 1 commit into
googleapis:mainfrom
pefoley2:main

Conversation

@pefoley2

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up unused local variables in the Pub/Sub sample files. In iam_samples.cc, the unused topic and subscription variables are removed, and the return values of CreateTopic and CreateSubscription are chained directly to .value(). In topic_admin_samples.cc, an unused google::protobuf::Timestamp timestamp variable is removed. I have no feedback to provide on these changes.

@colinmoy

Copy link
Copy Markdown
Collaborator

/gcbrun

@scotthart

Copy link
Copy Markdown
Member

/gcbrun

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.37%. Comparing base (c0ab3df) to head (484b0ed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16576      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files        2266     2266              
  Lines      219636   219634       -2     
==========================================
- Hits       202903   202896       -7     
- Misses      16733    16738       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
false — 484b0edf Deployed Oct 19, 2026 by pefoley2 via Save PR ref #12509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants