feat: update gapic-common for generated libraries to 1.4 - #1358
Merged
Merged
Conversation
gapic-common 1.4.0 requires grpc >= 1.83, the first grpc release that negotiates the X25519MLKEM768 post-quantum key exchange by default (googleapis/ruby-core-libraries#73). Generated clients previously declared gapic-common "~> 1.3", which permits 1.4.0 but also lets a resolver backtrack to 1.3.0 and its grpc "~> 1.66" constraint. Raising the emitted floor to "~> 1.4" makes a PQC-capable grpc a hard requirement of every regenerated client. Goldens regenerated with `toys gen`.
quartzmo
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gapic-common 1.4.0 requires
grpc >= 1.83, the first grpc release that negotiates theX25519MLKEM768post-quantum key exchange by default (googleapis/ruby-core-libraries#73).Generated clients currently declare
gapic-common "~> 1.3". That permits 1.4.0 but does not require it: a resolver can backtrack to 1.3.0 and itsgrpc "~> 1.66"constraint, silently landing on a classical-only transport. Raising the emitted floor to"~> 1.4"guarantees that every client version released from now on runs on a PQC-capable grpc.Scope: this does not make PQC a hard requirement for applications. Bundler can still backtrack the client gem itself to an older release that allows a classical-only grpc. A hard guarantee is only possible at the application level, e.g. by requiring
grpc ">= 1.83"in the app's own Gemfile.Changes
gem_presenter.rb: defaultgapic-commondependency~> 1.3→~> 1.4.toys gen; one line each.Not changed:
compute_smallandcompute_small_wrapperpingapic-common: ">= 1.1|< 2.a"in their configs, which overrides the default by design. Production libraries that setruby-cloud-extra-dependencies=gapic-common=…behave the same way and will need their own update.Follows the precedent set by #1223 (
feat: update gapic-common for generated libraries to 1.2).