perf: optimize checksum calculation with IncrementalHash#764
Open
olavloite wants to merge 2 commits into
Open
Conversation
Use IncrementalHash for calculating the checksum of a transaction, rather than creating a new SHA256 instance for every row.
There was a problem hiding this comment.
Code Review
This pull request refactors SpannerDataReaderWithChecksum to use IncrementalHash (SHA256) for running checksum calculations instead of re-calculating it from scratch on every row, which improves performance and reduces allocations. It also caches the final checksum upon disposal to support transaction retries. The reviewer suggests optimizing the CodedOutputStream instantiation in AppendRowToHash by specifying a smaller buffer size (e.g., 256 bytes) to further reduce per-row memory allocations and mitigate GC pressure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use IncrementalHash for calculating the checksum of a transaction, rather than creating a new SHA256 instance for every row.