Repository navigation
Conversation
38332b2 to
be6560f
Compare
be6560f to
99bbbd2
Compare
99bbbd2 to
e33f515
Compare
|
I rebased changes onto the latest main and removed support for |
richmckeever
left a comment
There was a problem hiding this comment.
There are places, such as MakeTypeCheckedNumberOrEnumValue in inference_table_utils.cc has a case for use which returns UnimplementedError. We should make those consider UseTreeEntry appropriately and add test cases. An AI search would be a good idea for that, since they don't have uniform search criteria.
e33f515 to
263860f
Compare
263860f to
cff75b4
Compare
Resolves use-bound constants, functions, structs, and type aliases, directly or via ColonRef on a whole-module use subject. Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Lets them be used as parametric defaults and bitwidth expressions, not just directly. Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
A free variable naming the module itself, not one of its members, was incorrectly assumed to always resolve to a constant. Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Covers use-syntax mechanics and per-entity-kind resolution; re-enables the use-syntax e2e DSLX tests disabled pending TIv2 support. Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
GitHub regenerated the slang archive, so the checksum in the registry no longer matches it. Internal-tag: [#102999] Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
cff75b4 to
ab4982e
Compare
|
I have found a few more corner cases, for example around importing constant @richmckeever PTAL I also added one do-not-merge commit on top, because with the current state of this repository I cannot build this branch correctly without it. It should be dropped later on when proper fix for |
This PR adds support for
usesupport in TIv2, and makes it operational with bytecode interpreter that relies on TIv1 data structures.What's included:
ColonRefon a whole-module use subject, including nested module pathsImplementation details:
ImportDatahelpers (ResolveUseImportedTarget,GetUseImportedModuleInfo) let the typechecker and bytecode emitter resolve a use-bound name consistentlyColonRefresolution now distinguishes a whole-module use subject from a use-bound value.config/.next/.initkeys to the same entry. Since all four resolve to the same proc, the identifier's suffix is the only signal for which member was meant. This suffix lookup runs independently at typecheck time and at bytecode-emission time.This PR also re-enables the use-syntax end-to-end DSLX tests that were previously disabled pending TIv2 support.