Skip to content

Document Plane and geometry filter APIs#373

Open
faheemabbas766 wants to merge 1 commit into
google:masterfrom
faheemabbas766:codex/document-plane-and-filter-apis
Open

Document Plane and geometry filter APIs#373
faheemabbas766 wants to merge 1 commit into
google:masterfrom
faheemabbas766:codex/document-plane-and-filter-apis

Conversation

@faheemabbas766

Copy link
Copy Markdown

Documents public APIs that are part of the vector_math public surface:

  • Plane in vector_math and vector_math_64
  • geometry filter classes in vector_math_geometry

Also updates the default GeometryFilter.requires and GeometryFilter.generates implementations to return const empty lists.

Part of flutter/flutter#186827.
Related Flutter mirror PRs: flutter/core-packages#12 and flutter/core-packages#22.

Validation

  • dart format --set-exit-if-changed lib/src/vector_math/plane.dart lib/src/vector_math_64/plane.dart lib/src/vector_math_geometry/filters/barycentric_filter.dart lib/src/vector_math_geometry/filters/color_filter.dart lib/src/vector_math_geometry/filters/flat_shade_filter.dart lib/src/vector_math_geometry/filters/geometry_filter.dart lib/src/vector_math_geometry/filters/invert_filter.dart lib/src/vector_math_geometry/filters/transform_filter.dart
  • dart analyze (completed with existing unrelated informational lints in lib/src/vector_math_operations/matrix.dart)
  • dart test test/geometry_test.dart test/plane_test.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant