Repository navigation
Return a kNotFound status from contention profile conversion when synchronization profiling is disabled. - #1796
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1011438945
branch
from
November 1, 2026 06:31
c5f3f23 to
f802908
Compare
…ynchronization profiling is disabled. When the synchronization profile period is set to zero, both cumulative and delta contention profile conversion previously encoded an empty profile proto, causing callers to respond with HTTP 200 and an empty payload rather than HTTP 404. Expose the recorded sampling period on `DeltaContentionProfile` and return a not-found error from `CollectContentionProto` and `MakeDeltaContentionProfile` whenever the sampling period is non-positive. Add HTTP handler tests covering disabled cumulative and delta contention requests. Co-authored-by: Chris Kennelly <ckennelly@google.com> PiperOrigin-RevId: 1011438945
copybara-service
Bot
force-pushed
the
test_1011438945
branch
from
November 1, 2026 07:42
f802908 to
4fbd6fd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return a
kNotFoundstatus from contention profile conversion when synchronization profiling is disabled.When the synchronization profile period is set to zero, both cumulative and delta contention profile conversion previously encoded an empty profile proto, causing callers to respond with HTTP 200 and an empty payload rather than HTTP 404.
Expose the recorded sampling period on
DeltaContentionProfileand return a not-found error fromCollectContentionProtoandMakeDeltaContentionProfilewhenever the sampling period is non-positive. Add HTTP handler tests covering disabled cumulative and delta contention requests.Co-authored-by: Chris Kennelly ckennelly@google.com