Repository navigation
Return NotFound when serializing allocation or lifetime profiles collected with sampling disabled. - #1795
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Return NotFound when serializing allocation or lifetime profiles collected with sampling disabled.#1795copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1011438924
branch
2 times, most recently
from
November 1, 2026 16:28
640ef0a to
598bb64
Compare
copybara-service
Bot
changed the title
kNotFound status when profile sampling is disabled.
copybara-service
Bot
force-pushed
the
test_1011438924
branch
4 times, most recently
from
November 2, 2026 04:00
0608689 to
56af6f4
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_1011438924
branch
from
November 2, 2026 04:17
56af6f4 to
2aefa46
Compare
…ected with sampling disabled. When TCMalloc profile sampling is disabled with a non-positive sampling interval, starting allocation or lifetime profiling previously constructed sample tables with sampling interval 1 and serialized an empty profile proto. HTTP profile handlers therefore returned 200 OK with an empty payload instead of signaling that sampling is disabled. Make ProfileBase::SamplingInterval pure virtual across StackTraceTable, DeallocationStackTraceTable, and FakeProfile, preserve the configured sampling interval when sampling is disabled, and return a not-found error from MakeProfileProto when the recorded interval is non-positive. Add unit and handler tests covering both normal and sanitizer builds. Co-authored-by: Chris Kennelly <ckennelly@google.com> PiperOrigin-RevId: 1011438924
copybara-service
Bot
force-pushed
the
test_1011438924
branch
from
November 2, 2026 04:31
2aefa46 to
86788b5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return NotFound when serializing allocation or lifetime profiles collected with sampling disabled.
When TCMalloc profile sampling is disabled with a non-positive sampling interval, starting allocation or lifetime profiling previously constructed sample tables with sampling interval 1 and serialized an empty profile proto. HTTP profile handlers therefore returned 200 OK with an empty payload instead of signaling that sampling is disabled.
Make ProfileBase::SamplingInterval pure virtual across StackTraceTable, DeallocationStackTraceTable, and FakeProfile, preserve the configured sampling interval when sampling is disabled, and return a not-found error from MakeProfileProto when the recorded interval is non-positive. Add unit and handler tests covering both normal and sanitizer builds.
Co-authored-by: Chris Kennelly ckennelly@google.com