Skip to content

Update 1-resman tfvars sample to align with TDD example - #78

Open
LanceWray wants to merge 1 commit into
mainfrom
wraylance-resman-tfvars-samp-update
Open

Update 1-resman tfvars sample to align with TDD example#78
LanceWray wants to merge 1 commit into
mainfrom
wraylance-resman-tfvars-samp-update

Conversation

@LanceWray

Copy link
Copy Markdown
Collaborator

Description

Update 1-resman tfvars sample to align with TDD example

Fixes # (GitHub issue id)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Deployment & Compliance Impact

  • Applicable Regimes:
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • General / All
  • NIST 800-53r5 Controls: (If this PR helps satisfy or modifies control implementations, list them here)

Checklist

Code Quality & Reusability

  • My code adheres to the Maximize Reusability principle. I have not redefined common elements and have reused existing base configurations and modules where possible.
  • I have checked that no existing module or configuration in modules/ or fast/ can be leveraged for this change.
  • My code follows the established naming conventions outlined in documentation/naming-convention.md.

Documentation

  • I have updated the README.md of the modified module or blueprint.
  • I have added/updated documentation for inputs (variables) and outputs.

Security

  • My change adheres to GCP security best practices and the principle of least privilege.
  • I have ensured compliance with the targeted regime (FedRAMP High, IL5, etc.).

Testing

  • I have tested my changes locally.
  • I have included details of my testing in this PR.

Testing Performed

Deployed locally using updated sample tfvars

Comment thread fast/stages-aw/1-resman/terraform.tfvars.sample Outdated
Comment thread fast/stages-aw/1-resman/terraform.tfvars.sample Outdated

@woodham1 woodham1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to do it here in resman, we should probably do the same for the other samples.

@aghassemlouei aghassemlouei added bug Something isn't working Priority - High Critical issues blocking development or users; urgent bugs or core features for release Level of Effort - Medium Moderate task requiring thought and testing; typically takes a couple of days to a week documentation Improvements or additions to documentation labels Aug 28, 2026
@aghassemlouei aghassemlouei added Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent and removed Priority - High Critical issues blocking development or users; urgent bugs or core features for release labels Sep 5, 2026
@aghassemlouei
aghassemlouei force-pushed the wraylance-resman-tfvars-samp-update branch from 5800054 to 0619f00 Compare September 6, 2026 16:30
@aghassemlouei

Copy link
Copy Markdown
Collaborator

Reviewed this PR.

Summary of Changes & Value

This PR updates fast/stages-aw/1-resman/terraform.tfvars.sample to align with the Deployment Design Guide (docs/ddg.md) and resolves a blocking validation issue:

  • Tenant Key Length Validation: Variable validation in fast/stages-aw/1-resman/variables.tf enforces length(k) < 7 for all keys in var.tenants. The prior sample used tenant_name (11 chars) and tenant_name-2 (13 chars), causing immediate plan/apply validation errors when users copied the sample. Changing the sample keys to ten-1 and ten-2 (<= 6 chars) ensures the sample passes schema validation.
  • Placeholder Alignment: Updates domain and region placeholders to match docs/ddg.md (<domain>, <region>).

Addressing Review Feedback

Regarding the previous review note about standardizing placeholders across all stage samples:

  1. Stage 1 (1-resman) uniquely suffered from a hard variable validation failure due to the 6-character constraint on tenant keys, making this sample fix an immediate operational priority.
  2. Standardizing placeholders (e.g. <domain>, <region>) across all stage samples (0-bootstrap, 2-networking, 3-security) is best handled in a dedicated documentation hygiene PR to keep this functional fix scoped and low-risk.
  3. Note for a follow-up PR: fast/stages-aw/1-resman/README.md lines 147–165 also reference example tenant keys wingarch (8 chars) and fuselagerd (10 chars) which exceed the 6-character validation rule and should be updated.

Rebase & Status

  • Rebased cleanly onto latest main (9578437b).
  • Cleaned up block indentation in fast/stages-aw/1-resman/terraform.tfvars.sample (ten-2 locations and Test environment block).
  • Pushed rebased commit 0619f00e directly to origin/wraylance-resman-tfvars-samp-update.
  • Verified GitHub PR mergeability state is clean (mergeable: true, 0 conflicts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation Level of Effort - Medium Moderate task requiring thought and testing; typically takes a couple of days to a week Priority - Medium Standard features and non-blocking bugs; important for the current milestone but not urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants