fix(gemini-enterprise): resolve stage-0 teardown, internal VIP sharing, and access day bounds - #225
Open
aghassemlouei wants to merge 1 commit into
Open
fix(gemini-enterprise): resolve stage-0 teardown, internal VIP sharing, and access day bounds#225aghassemlouei wants to merge 1 commit into
aghassemlouei wants to merge 1 commit into
Conversation
…g, and access day bounds - analytics.tf: Set delete_contents_on_destroy = true on google_bigquery_dataset.analytics_dataset so terraform destroy does not fail on sink-written tables. (Fixes #174) - network.tf: Set purpose = "SHARED_LOADBALANCER_VIP" on internal compute address to allow sharing the VIP between HTTP redirect (:80) and HTTPS (:443) forwarding rules. (Fixes #185) - variables.tf, deploy.sh, README.md, terraform.tfvars.sample: Update access_start_day and access_end_day documentation to reflect CEL getDayOfWeek convention (0=Sunday..6=Saturday) and add validation blocks for 0..6 range. (Fixes #186)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses three issues in
blueprints/fedramp-high/gemini-enterprise/gemini-stage-0:delete_contents_on_destroy):Sets
delete_contents_on_destroy = trueongoogle_bigquery_dataset.analytics_datasetinanalytics.tf. Without this flag,terraform destroyfails whenever the Discovery Engine audit log sink has written date-partitioned tables to the dataset.SHARED_LOADBALANCER_VIP):Sets
purpose = var.deployment_type == "internal" ? "SHARED_LOADBALANCER_VIP" : nullongoogle_compute_address.gemini_enterprise_ipinnetwork.tf. This allows the port 80 HTTP redirect forwarding rule in stage-0 and the port 443 HTTPS forwarding rule in stage-1 to share the same internal IP address without conflicting.getDayOfWeek()):Corrects
access_start_dayandaccess_end_daydocumentation acrossvariables.tf,deploy.sh,README.md, andterraform.tfvars.sampleto reflect the 0-indexed convention of CEL'sgetDayOfWeek()(0 = Sunday ... 6 = Saturday) rather than ISO-8601 (1..7). Adds Terraformvalidationblocks enforcing the0..6range.Fixes #174
Fixes #185
Fixes #186
Type of Change
Deployment & Compliance Impact
Checklist
Code Quality & Reusability
modules/orfast/can be leveraged for this change.documentation/naming-convention.md.Documentation
README.mdof the modified module or blueprint.Security
Testing
Testing Performed
tofu fmt -check: Verified all modified Terraform files format cleanly with zero diffs.bash -n deploy.sh: Verified shell syntax passes without errors.terraform init -backend=false && terraform validate: Executed inblueprints/fedramp-high/gemini-enterprise/gemini-stage-0/confirmingSuccess! The configuration is valid.