docs: node-configuration - target_url works for type: mcp, not just H… - #380
Merged
Merged
Conversation
…TTP/inference/A2A The property table and example config only showed command (stdio subprocess) for MCP services, and described target_url as HTTP/inference/A2A only. That's not what the code does: buildRegisterRequest maps target_url to a backend regardless of service type, and MCPService.backendTransport() proxies to it the same way for MCP as any other type - verified end to end against a real Streamable HTTP MCP server, not just by reading the source. Adds a second MCP example (HTTP backend via target_url, no subprocess) and clarifies the two backend kinds are mutually exclusive.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the node configuration documentation to include an example and detailed descriptions for exposing an existing HTTP MCP server using the target_url parameter, clarifying that it is mutually exclusive with the command parameter. The review feedback suggests a grammatical improvement to the description of target_url to fix a comma splice and use more standard phrasing.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…TTP/inference/A2A
The property table and example config only showed command (stdio subprocess) for MCP services, and described target_url as HTTP/inference/A2A only. That's not what the code does: buildRegisterRequest maps target_url to a backend regardless of service type, and MCPService.backendTransport() proxies to it the same way for MCP as any other type - verified end to end against a real Streamable HTTP MCP server, not just by reading the source.
Adds a second MCP example (HTTP backend via target_url, no subprocess) and clarifies the two backend kinds are mutually exclusive.