resolve goroutine leak in serveOnPipe - #359
Open
IbrahimAhmed8 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a goroutine leak in serveOnPipe by ensuring that the singleConnListener is closed when the underlying connection is closed, which unblocks http.Server.Serve from Accept. A new test TestSingleConnListenerServeExitsOnConnClose is added to verify this behavior. The reviewer suggested simplifying closeNotifyConn by removing the redundant sync.Once synchronization, as the listener's Close method already handles one-time execution.
IbrahimAhmed8
force-pushed
the
fix_mesh_leak
branch
4 times, most recently
from
September 5, 2026 18:54
1898b7a to
04a6658
Compare
aojea
reviewed
Sep 6, 2026
Comment on lines
+61
to
+74
| cache: true | ||
| - name: Set up JDK | ||
| uses: actions/setup-java@dd06d9cba3e5552c54d9f8ea23572deb30010f7c # v6.0.0 | ||
| uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0 |
Collaborator
There was a problem hiding this comment.
this change seems unrelated, no?
Contributor
Author
There was a problem hiding this comment.
i'll revert that as it was included by mistake during local testing,
apologize
IbrahimAhmed8
force-pushed
the
fix_mesh_leak
branch
from
September 6, 2026 08:10
04a6658 to
3659351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #358