docs: clarify required discovery service type - #340
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the JSON schema description for the Type field in DiscoverRemoteServicesParams to clarify that it is required and lists the allowed values. The review feedback points out that a2a is not supported by the underlying protobuf definition and should be removed from the description.
| // DiscoverRemoteServicesParams defines the parameters for the discover_remote_services tool. | ||
| type DiscoverRemoteServicesParams struct { | ||
| Type string `json:"type" jsonschema:"Service type (mcp, inference, a2a)"` | ||
| Type string `json:"type" jsonschema:"Required. One of: mcp, inference, a2a."` |
There was a problem hiding this comment.
The jsonschema tag lists a2a as one of the accepted values (One of: mcp, inference, a2a.). However, the underlying ServiceType enum in api/sam.proto only defines SERVICE_TYPE_MCP and SERVICE_TYPE_INFERENCE. Passing a2a will fail during api.ParseServiceType(params.Type) and return an error. Please remove a2a from the description unless it is supported by the protobuf definition.
| Type string `json:"type" jsonschema:"Required. One of: mcp, inference, a2a."` | |
| Type string `json:"type" jsonschema:"Required. One of: mcp, inference."` |
|
CI note: the failing e2e-android job timed out in mobile_e2e.sh while waiting 15 seconds for the host-node /mcp endpoint (exit 124). The same failure occurred in run 33445421284 on another PR, and a subsequent run on that branch passed. This patch only changes a jsonschema description; the other 12 checks, including Go tests, lint, Bats, and mesh E2E, passed. I do not have repository permission to rerun the failed job. Could a maintainer rerun e2e-android after the CLA is signed? |
|
please rebase to get the latest ci fixes and sign the cla, thanks |
508e6e4 to
4f73afb
Compare
|
Rebased onto main and force pushed. The commit also carries the address that is on my GitHub account now, it went out under an old one before. CLA is next on my list. |
|
@googlebot I signed it! |
4f73afb to
8c2d263
Compare
Summary
Addresses #322.
Testing
A full go test ./internal/node run was also attempted; an unrelated macOS-only test setup failure occurs because the generated Unix socket path is 119 bytes while the kernel limit is 103.