Repository navigation
Conversation
Collaborator
|
Some general feedback:
|
mrober
enabled auto-merge (squash)
October 22, 2026 15:25
kaibolay
reviewed
Oct 22, 2026
mrober
disabled auto-merge
October 23, 2026 16:49
mrober
enabled auto-merge (squash)
October 23, 2026 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the 4.4.0 Kotlin rewrite, the plugin could be applied to
com.android.librarymodules. The rewrite dropped that support because the new Variant API'sLibraryVarianthas noapplicationId, which the plugin used to select the matching client entry in the google-services.json fileThis change restores library support by using the library's
namespaceas thepackage_namekey instead, which is effectively the same value the legacy plugin matched onThis lets library modules generate Firebase resources without a consuming app, e.g. a library's own instrumentation tests that need to initialize Firebase, instead of forcing a throwaway app module solely to host google-services.json. Resources generated in a library merge into dependent apps with normal AGP precedence, so the app's own values always win