ui: offer node actions in the Call Tree and Functions views - #7316
Draft
LalitMaganti wants to merge 1 commit into
Draft
ui: offer node actions in the Call Tree and Functions views#7316LalitMaganti wants to merge 1 commit into
LalitMaganti wants to merge 1 commit into
Conversation
The flamegraph tooltip has long offered the embedder's node actions (e.g. "View source & assembly" for stack samples) but the Call Tree and Functions tables had no way to reach them. Both now end with an actions column whose menu lists the same actions for the row's node. A Functions row aggregates several nodes, so it acts on the one with the largest self value, which is the best representative when an action needs a sampled address.
LalitMaganti
changed the title
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flamegraph tooltip has long offered the embedder's node actions
(e.g. "View source & assembly" for stack samples) but the Call Tree and
Functions tables had no way to reach them. Both now end with an actions
column whose menu lists the same actions for the row's node. A Functions
row aggregates several nodes, so it acts on the one with the largest
self value, which is the best representative when an action needs a
sampled address.