feat(monitoring): set up initial GMP metrics & minimal test dashboard - #5964
Open
jess-lowe wants to merge 11 commits into
Open
feat(monitoring): set up initial GMP metrics & minimal test dashboard#5964jess-lowe wants to merge 11 commits into
jess-lowe wants to merge 11 commits into
Conversation
another-rex
reviewed
Sep 2, 2026
Comment on lines
+30
to
+43
| - name: GF_SECURITY_ALLOW_EMBEDDING | ||
| value: "true" | ||
| - name: GF_AUTH_ANONYMOUS_ENABLED | ||
| value: "false" | ||
| - name: GF_AUTH_BASIC_ENABLED | ||
| value: "false" | ||
| - name: GF_AUTH_PROXY_ENABLED | ||
| value: "true" | ||
| - name: GF_AUTH_PROXY_HEADER_NAME | ||
| value: "X-Goog-Authenticated-User-Email" | ||
| - name: GF_AUTH_PROXY_HEADER_PROPERTY | ||
| value: "email" | ||
| - name: GF_AUTH_PROXY_AUTO_SIGN_UP | ||
| value: "true" |
Contributor
There was a problem hiding this comment.
This is going to need more work to get working I believe.
Apparently the Auth proxy header doesn't work with google. Try JWTs.
You'll also need to look into how oauth and cloud IAM is setup and how it can be used to authenticate grafana.
Also, we probably want to set: GF_USERS_AUTO_ASSIGN_ORG_ROLE to be admin, instead of the default viewer. We'll need to figure out persistent accounts later. Right now for testing allow anyone with the google cloud perms to have write access.
Contributor
Author
There was a problem hiding this comment.
I have done the oauth and iam service account. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the basic Prometheus scraping and Grafana infrastructure, instrumenting the worker with a single test metric (
osv_worker_tasks_processed_total) to confirm end-to-end telemetry onoss-vdb-test.go/internal/metrics):osv_worker_tasks_processed_totalcounter withstatuslabel (success,error,skipped).:9090serving/metricsand/healthz.go/cmd/worker/,go/internal/worker/):deployment/clouddeploy/.../environments/oss-vdb-test/monitoring/):PodMonitoringCRD for GMP to scrape workers every 15s.oss-vdb-test).deployment/terraform/modules/osv_pipeline/):osv-monitoring-saGCP service account, monitoring/logging viewer roles, and Workload Identity binding fordefault/grafana-sa.