chore(dep): update go to v1.27, golangci-lint to v2.13, and fix all the lint - #5959
Merged
Conversation
Ly-Joey
requested review from
a team and
michaelkedar
and removed request for
a team and
michaelkedar
September 2, 2026 01:42
This was referenced Sep 2, 2026
another-rex
previously approved these changes
Sep 2, 2026
Ly-Joey
force-pushed
the
chore-update-golangci-lint
branch
2 times, most recently
from
September 2, 2026 04:00
c2dde22 to
0918e24
Compare
another-rex
reviewed
Sep 2, 2026
another-rex
left a comment
another-rex
left a comment
Contributor
There was a problem hiding this comment.
also update the go version in lint.yaml in .workflows
Ly-Joey
force-pushed
the
chore-update-golangci-lint
branch
from
September 2, 2026 07:14
4aa2b00 to
4853559
Compare
Ly-Joey
changed the title
cuixq
approved these changes
Sep 3, 2026
This was referenced Sep 3, 2026
Ly-Joey
added a commit
that referenced
this pull request
Sep 4, 2026
nolint:gosec and nolintlint are fighting so we're switching to the gosec native ignore pattern. Seems like our lint workflow only intermittently report the nolintlint error, which is why #5959 was fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Go module directives and Docker base images to Go
1.27.0.Go 1.27 introduced a new compiler export data format (v4) for compiled standard library packages. Older versions of
golangci-lintfail during typechecking when encountering Go 1.27 standard library export data, so we are updating it tov2.13.0as well.Also added a golangci config file to disable
exhaustruct_v5and fixed ALL the new lint errors found.