Reject directory stdio fds unless explicitly passed#268
Open
Vincent550102 wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
b130ec3 to
9d41a57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject directory file descriptors on the default stdio fds before executing the jailed process.
nsjail keeps fd
0,1, and2open by default. If one of those descriptors is a directory fd, the jailed process can still use it as a filesystem capability afterexecvewith calls such asfchdir(2)oropenat(2).This change fails closed when a default stdio fd is a directory. Explicit
--pass_fd/ configpass_fdbehavior is preserved, so users who intentionally pass a directory fd can still do so explicitly.Changes
--pass_fdor configpass_fd.0,1, and2unless explicitly passed.--pass_fdhelp text.--pass_fd 0.Testing
Passed.
Returned
255as expected and rejected default directory stdin.Returned
0as expected and preserved explicit--pass_fd 0behavior.The newly added stdio-fd regression tests passed. The full test run stopped later at the existing
tests/pasta-nat.cfgcase because ping inside the pasta NAT test returned1instead of the expected77. I reproduced the sametests/pasta-nat.cfgfailure on an unmodifiedHEADworktree in this environment, so it is not introduced by this change.