Migrate core entities and billing to java.time#3020
Open
CydeWeys wants to merge 1 commit intogoogle:masterfrom
Open
Migrate core entities and billing to java.time#3020CydeWeys wants to merge 1 commit intogoogle:masterfrom
CydeWeys wants to merge 1 commit intogoogle:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Optional.ofNullable(getLastSuperordinateChange()).orElse(getCreationTimeInstant()); | ||
| Instant lastTransferOfCurrentSuperordinate = | ||
| Optional.ofNullable(superordinateDomain.getLastTransferTimeInstant()).orElse(START_INSTANT); | ||
| Optional.ofNullable(superordinateDomain.getLastTransferTime()) |
| RegistryLockDao.getLocksByRegistrarId(registrarId).stream() | ||
| .filter(lock -> !lock.isLockRequestExpired(tm().getTransactionTime())) | ||
| .filter( | ||
| lock -> !lock.isLockRequestExpired(toInstant(tm().getTransactionTime()))) |
| .setTargetId(existingDomain.getDomainName()) | ||
| .setRegistrarId("TheRegistrar") | ||
| .setEventTime(existingDomain.getCreationTime()) | ||
| .setEventTime(toInstant(existingDomain.getCreationTime())) |
| .setRegistrarId("TheRegistrar") | ||
| .setEventTime(domain.getRegistrationExpirationDateTime()) | ||
| .setRecurrenceEndTime(END_OF_TIME) | ||
| .setEventTime(toInstant(domain.getRegistrationExpirationDateTime())) |
| .hasPersistedCurrentSponsorRegistrarId("TheRegistrar") | ||
| .and() | ||
| .hasLastTransferTime(domain.getLastTransferTime()); | ||
| .hasLastTransferTime(toInstant(domain.getLastTransferTime())); |
| BillingCancellation.forGracePeriod( | ||
| GracePeriod.forBillingEvent(GracePeriodStatus.ADD, domain.getRepoId(), billingEvent), | ||
| domainHistory2.getModificationTime(), | ||
| toInstant(domainHistory2.getModificationTime()), |
| "TheRegistrar", | ||
| billingRecurrence.createVKey()), | ||
| domainHistory2.getModificationTime(), | ||
| toInstant(domainHistory2.getModificationTime()), |
| toInstant(now.plusDays(1)), | ||
| "a registrar"), | ||
| domainHistory.getModificationTime(), | ||
| toInstant(domainHistory.getModificationTime()), |
| .setRenewalPriceBehavior(renewalPriceBehavior) | ||
| .setRegistrarId(domain.getCreationRegistrarId()) | ||
| .setEventTime(domain.getCreationTime()) | ||
| .setEventTime(toInstant(domain.getCreationTime())) |
CydeWeys
force-pushed
the
javatime-refactor-5th
branch
from
70ce744 to
ca32534
Compare
Migrated core entity primitives (GracePeriod, RegistryLock, TimeOfYear), transfer objects (BaseTransferObject, DomainTransferData, TransferResponse) and HostBase from Joda-Time DateTime to java.time.Instant as Phases 5 and 7. Migrated the Billing Ecosystem (BillingBase, BillingEvent, BillingRecurrence, BillingCancellation) and associated Beam pipelines (ExpandBillingRecurrencesPipeline, InvoicingPipeline) to java.time.Instant as Phase 6. Updated all associated EPP flows, tools, and testing helpers to handle Instants directly where supported.
CydeWeys
force-pushed
the
javatime-refactor-5th
branch
from
ca32534 to
0752d32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated core entity primitives (GracePeriod, RegistryLock, TimeOfYear), transfer objects (BaseTransferObject, DomainTransferData, TransferResponse) and HostBase from Joda-Time DateTime to java.time.Instant. Migrated the Billing Ecosystem (BillingBase, BillingEvent, BillingRecurrence, BillingCancellation) and associated Beam pipelines (ExpandBillingRecurrencesPipeline, InvoicingPipeline) to java.time.Instant. Updated all associated EPP flows, tools, and testing helpers to handle Instants directly where supported.
This change is