Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
`ClassifyLicenses` closes the `task` channel once the wait group drains, but each worker's deferred cleanup calls `wg.Done()` before `task <- true`. The closer goroutine can run between the two, and the final send panics with `send on closed channel`. Nothing ranges over `task`, so it is now left open. google#21 fixed the same panic in the v1 backend, but the v2 copy still had it. Also fixed in the same backend: - `ClassifyLicensesWithContext` returned as soon as ctx was done but left the classification running in the background, racing on the named return, leaking the goroutine, and appending results into later calls on the same backend. ctx is now checked in the dispatch loop: once it is done no new files start, in-flight files finish, and the call returns `ctx.Err()`. Nothing outlives the call, though it can return slightly after the deadline. - `GetResults` read `b.results` without the lock. It now reads under the lock and returns a copy. Signed-off-by: Alex Goodman <wagoodman@gmail.com>
wagoodman
force-pushed
the
fix/identify-license-send-on-closed-channel
branch
from
October 2, 2026 15:20
bc0b185 to
37ddd00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassifyLicensescloses thetaskchannel once the wait group drains, but each worker's deferred cleanup callswg.Done()beforetask <- true. The closer goroutine can run between the two, and the final send panics withsend on closed channel. Nothing ranges overtask, so it is now left open. #21 fixed the same panic in the v1 backend, but the v2 copy still had it.Also fixed in the same backend:
ClassifyLicensesWithContextreturned as soon as ctx was done but left the classification running in the background, racing on the named return, leaking the goroutine, and appending results into later calls on the same backend. ctx is now checked in the dispatch loop: once it is done no new files start, in-flight files finish, and the call returnsctx.Err(). Nothing outlives the call, though it can return slightly after the deadline.GetResultsreadb.resultswithout the lock. It now reads under the lock and returns a copy.