Use UIImage instead of CGImage for brush-texture interfaces - #800
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_975731621
branch
4 times, most recently
from
September 10, 2026 18:05
133c5ec to
e635201
Compare
UIImage has the advantage of being memory-managed and owning the underlying CGImage. The disadvantage is that it can also wrap CIImage and behaves differently depending on which it wraps. The code is updated to handle both cases, though there's a performance penalty if the UIImage isn't pre-loaded (the wrapping-CIImage case). PiperOrigin-RevId: 979292670
copybara-service
Bot
force-pushed
the
test_975731621
branch
from
September 10, 2026 18:22
e635201 to
27e8e43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use UIImage instead of CGImage for brush-texture interfaces
UIImage has the advantage of being memory-managed and owning the underlying CGImage. The disadvantage is that it can also wrap CIImage and behaves differently depending on which it wraps. The code is updated to handle both cases, though there's a performance penalty if the UIImage isn't pre-loaded (the wrapping-CIImage case).