Add control-rpc-stop-timeout flag for control socket#12886
Open
AmitPr wants to merge 1 commit intogoogle:masterfrom
Open
Add control-rpc-stop-timeout flag for control socket#12886AmitPr wants to merge 1 commit intogoogle:masterfrom
control-rpc-stop-timeout flag for control socket#12886AmitPr wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a container shuts down with clients connected to the control socket, the
runscprocess will hang for 15 seconds due to the nonconfigurable shutdown timeout in the urpc server. This PR adds a-control-rpc-stop-timeoutflag that allows us to adjust the shutdown timeout.Context is that we have a resource monitor that creates a persistent connection to the
runsccontrol socket. This connection lasts for the lifetime of the container, we currently send requests to fetch memory usage (approximatingrunsc usage -full). We can't runrunsc usage -fullbecause we manage hundreds of containers per host andrunsc usage -fullseems to degrade our hosts under load.