Repository navigation
Validate and invalidate Graphs.transpose(graph).incidentEdges(node) like other graph views. - #8894
Merged
Merged
Conversation
… like other graph views. The transposed `Graph`'s `incidentEdges` returned a raw view without checking `node`, so it accepted absent (or null) nodes, and after `node` was removed its methods threw `IllegalArgumentException` instead of the documented `IllegalStateException`. It now delegates to the original graph's `incidentEdges` (which validates `node` immediately and preserves its iteration order) and wraps the result in the usual invalidatable view. Fixes #8867 Fixes #8868 RELNOTES=`graph`: Fixed `Graphs.transpose(graph).incidentEdges(node)` not rejecting absent nodes and throwing the wrong exception after `node` is removed. PiperOrigin-RevId: 1026654445
copybara-service
Bot
force-pushed
the
test_1022766148
branch
from
November 20, 2026 20:11
22a7232 to
36e3995
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate and invalidate
Graphs.transpose(graph).incidentEdges(node)like other graph views.The transposed
Graph'sincidentEdgesreturned a raw view without checkingnode, so it accepted absent (or null) nodes, and afternodewas removed its methods threwIllegalArgumentExceptioninstead of the documentedIllegalStateException. It now delegates to the original graph'sincidentEdges(which validatesnodeimmediately and preserves its iteration order) and wraps the result in the usual invalidatable view.Fixes #8867
Fixes #8868
RELNOTES=
graph: FixedGraphs.transpose(graph).incidentEdges(node)not rejecting absent nodes and throwing the wrong exception afternodeis removed.