Skip to content

Fix up some Javadoc mistakes, diffs between class/flavors, and obsolete bits. - #8893

Merged
copybara-service[bot] merged 1 commit into
masterfrom
test_1025589795
Nov 20, 2026
Merged

copybara-service[bot] merged 1 commit into
masterfrom
test_1025589795

Conversation

@copybara-service

Copy link
Copy Markdown
Contributor

Fix up some Javadoc mistakes, diffs between class/flavors, and obsolete bits.

(This comes after 9f81619 dealt with the straight-up malformed bits, including some that surface only with -private/-package. In particular, that CL addressed some invalid references that crept in after we disabled -Xdoclint internally.)

As part of preparing to enable even more -Xdoclint externally, it turns out to be important to fix up our HTML heading tags to use the correct numbers, since mistakes are flagged by the accessibility check. This is something that I'd done previously in 3072ff8 but not for:

  • backport-only docs (in base)
  • tags that include an id (ComparisonChain)
  • method-level headings in at least one case (MoreFiles)

In this case, the easy fix is sometimes to remove the heading entirely: Most problem sections were about "Java 8+" caveats that now apply universally: Functionality equivalent to them is now available in the Java standard library even under Android, thanks to the bump in the Google-wide minSdkVersion. (In the specific case of our functional types, they don't yet extend the JDK types there yet. We should see how much of an issue b/336342607 is nowadays.)

RELNOTES=n/a

…te bits.

(This comes after 9f81619 dealt with the straight-up malformed bits, including some that surface only with `-private`/`-package`. In particular, that CL addressed some invalid references that crept in after we disabled `-Xdoclint` internally.)

As part of preparing to enable even more `-Xdoclint` _externally_, it turns out to be important to fix up our HTML heading tags to use the correct numbers, since mistakes are flagged by the `accessibility` check. This is something that I'd done previously in 3072ff8 but not for:

- backport-only docs (in `base`)
- tags that include an `id` (`ComparisonChain`)
- method-level headings in at least one case (`MoreFiles`)

In this case, the easy fix is sometimes to remove the heading entirely: Most problem sections were about "Java 8+" caveats that now apply universally: Functionality equivalent to them is now available in the Java standard library even under Android, thanks to the bump in the Google-wide minSdkVersion. (In the specific case of our functional types, they don't yet _extend_ the JDK types there yet. We should see how much of an issue b/336342607 is nowadays.)

RELNOTES=n/a
PiperOrigin-RevId: 1026611277
@copybara-service
copybara-service Bot merged commit 23ddd04 into master Nov 20, 2026
15 checks passed
@copybara-service
copybara-service Bot deleted the test_1025589795 branch November 20, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant