Repository navigation
Fix up some Javadoc mistakes, diffs between class/flavors, and obsolete bits. - #8893
Merged
Merged
Conversation
…te bits. (This comes after 9f81619 dealt with the straight-up malformed bits, including some that surface only with `-private`/`-package`. In particular, that CL addressed some invalid references that crept in after we disabled `-Xdoclint` internally.) As part of preparing to enable even more `-Xdoclint` _externally_, it turns out to be important to fix up our HTML heading tags to use the correct numbers, since mistakes are flagged by the `accessibility` check. This is something that I'd done previously in 3072ff8 but not for: - backport-only docs (in `base`) - tags that include an `id` (`ComparisonChain`) - method-level headings in at least one case (`MoreFiles`) In this case, the easy fix is sometimes to remove the heading entirely: Most problem sections were about "Java 8+" caveats that now apply universally: Functionality equivalent to them is now available in the Java standard library even under Android, thanks to the bump in the Google-wide minSdkVersion. (In the specific case of our functional types, they don't yet _extend_ the JDK types there yet. We should see how much of an issue b/336342607 is nowadays.) RELNOTES=n/a PiperOrigin-RevId: 1026611277
copybara-service
Bot
force-pushed
the
test_1025589795
branch
from
November 20, 2026 19:08
592d0c8 to
23ddd04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix up some Javadoc mistakes, diffs between class/flavors, and obsolete bits.
(This comes after 9f81619 dealt with the straight-up malformed bits, including some that surface only with
-private/-package. In particular, that CL addressed some invalid references that crept in after we disabled-Xdoclintinternally.)As part of preparing to enable even more
-Xdoclintexternally, it turns out to be important to fix up our HTML heading tags to use the correct numbers, since mistakes are flagged by theaccessibilitycheck. This is something that I'd done previously in 3072ff8 but not for:base)id(ComparisonChain)MoreFiles)In this case, the easy fix is sometimes to remove the heading entirely: Most problem sections were about "Java 8+" caveats that now apply universally: Functionality equivalent to them is now available in the Java standard library even under Android, thanks to the bump in the Google-wide minSdkVersion. (In the specific case of our functional types, they don't yet extend the JDK types there yet. We should see how much of an issue b/336342607 is nowadays.)
RELNOTES=n/a