Skip to content

Add new Room setup to track incremental survey syncs - #3929

Merged
andreia-ferreira merged 6 commits into
masterfrom
andreia/3867/avoid-sync-all-lois-room
Sep 9, 2026
Merged

Add new Room setup to track incremental survey syncs#3929
andreia-ferreira merged 6 commits into
masterfrom
andreia/3867/avoid-sync-all-lois-room

Conversation

@andreia-ferreira

@andreia-ferreira andreia-ferreira commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Part 1 for #3918

This PR adds the database infrastructure needed to implement incremental survey syncs. A new Room table is added survey_sync_state. This table will be used to keep track of each survey sync state by storing the timestamp when a full sync last occurred, the server timestamp of the latest LOI read and the latest survey data visibility setting.

No new behavior is introduced, that will be done in the next PR

@shobhitagarwal1612 PTAL?

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.17073% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.74%. Comparing base (1e93f3d) to head (8a785ba).

Files with missing lines Patch % Lines
.../android/data/local/room/converter/ConverterExt.kt 53.84% 5 Missing and 1 partial ⚠️
...org/groundplatform/domain/model/SurveySyncState.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3929      +/-   ##
============================================
+ Coverage     69.73%   69.74%   +0.01%     
- Complexity     1986     1999      +13     
============================================
  Files           417      420       +3     
  Lines         11425    11466      +41     
  Branches       1486     1492       +6     
============================================
+ Hits           7967     7997      +30     
- Misses         2689     2699      +10     
- Partials        769      770       +1     
Files with missing lines Coverage Δ
...ava/org/groundplatform/android/common/Constants.kt 50.00% <ø> (ø)
...dplatform/android/data/local/room/LocalDatabase.kt 100.00% <ø> (ø)
...id/data/local/room/entity/SurveySyncStateEntity.kt 100.00% <100.00%> (ø)
...a/local/room/stores/RoomLocationOfInterestStore.kt 92.15% <100.00%> (+0.85%) ⬆️
...data/local/room/stores/RoomSurveySyncStateStore.kt 100.00% <100.00%> (ø)
...org/groundplatform/domain/model/SurveySyncState.kt 0.00% <0.00%> (ø)
.../android/data/local/room/converter/ConverterExt.kt 82.74% <53.84%> (-1.26%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andreia-ferreira
andreia-ferreira merged commit a047f34 into master Sep 9, 2026
19 checks passed
@andreia-ferreira
andreia-ferreira deleted the andreia/3867/avoid-sync-all-lois-room branch September 9, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants