Skip to content

chore: Resolve static analysis warnings and reduce detekt baseline suppressions - #3924

Open
shobhitagarwal1612 wants to merge 4 commits into
masterfrom
lint
Open

chore: Resolve static analysis warnings and reduce detekt baseline suppressions#3924
shobhitagarwal1612 wants to merge 4 commits into
masterfrom
lint

Merge branch 'master' into lint

9fb1b5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 8, 2026 in 1s

69.80% (+0.00%) compared to 8b167b3

View this Pull Request on Codecov

69.80% (+0.00%) compared to 8b167b3

Details

Codecov Report

❌ Patch coverage is 57.69231% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.80%. Comparing base (8b167b3) to head (9fb1b5f).

Files with missing lines Patch % Lines
...ta/local/room/converter/SubmissionDataConverter.kt 36.36% 5 Missing and 2 partials ⚠️
...droid/ui/datacollection/DataCollectionViewModel.kt 78.57% 2 Missing and 4 partials ⚠️
...dplatform/android/ui/map/gms/GoogleMapsFragment.kt 0.00% 3 Missing ⚠️
...undplatform/android/ui/home/HomeScreenViewModel.kt 0.00% 1 Missing and 1 partial ⚠️
...org/groundplatform/android/ui/main/MainActivity.kt 0.00% 2 Missing ⚠️
...roundplatform/android/ui/map/gms/mog/MogTileExt.kt 0.00% 1 Missing ⚠️
...va/org/groundplatform/android/ui/util/ColorUtil.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #3924   +/-   ##
=========================================
  Coverage     69.79%   69.80%           
  Complexity     1987     1987           
=========================================
  Files           415      415           
  Lines         11380    11379    -1     
  Branches       1486     1484    -2     
=========================================
  Hits           7943     7943           
+ Misses         2670     2669    -1     
  Partials        767      767
Files with missing lines Coverage Δ
...oundplatform/android/ui/home/HomeScreenFragment.kt 73.91% <100.00%> (ø)
...rg/groundplatform/android/ui/main/MainViewModel.kt 67.21% <100.00%> (+1.63%) ⬆️
...g/groundplatform/android/ui/signin/SignInScreen.kt 63.07% <ø> (ø)
...latform/android/util/image/TileImageTransformer.kt 92.30% <100.00%> (ø)
...roundplatform/android/ui/map/gms/mog/MogTileExt.kt 20.00% <0.00%> (ø)
...va/org/groundplatform/android/ui/util/ColorUtil.kt 80.00% <0.00%> (ø)
...undplatform/android/ui/home/HomeScreenViewModel.kt 80.43% <0.00%> (+2.88%) ⬆️
...org/groundplatform/android/ui/main/MainActivity.kt 44.31% <0.00%> (+0.49%) ⬆️
...dplatform/android/ui/map/gms/GoogleMapsFragment.kt 18.10% <0.00%> (ø)
...droid/ui/datacollection/DataCollectionViewModel.kt 80.93% <78.57%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov