Migrate Sync Status Screen to Compose - #3923
Open
shobhitagarwal1612 wants to merge 2 commits into
Open
Conversation
shobhitagarwal1612
requested a deployment
to
e2e-approval
September 8, 2026 11:56 — with
GitHub Actions
Waiting
- Replace sync_status_frag.xml with pure Compose SyncStatusScreen - Convert SyncStatusViewModel from LiveData to StateFlow<SyncStatusState> - Annotate SyncStatusDetail and SyncStatusState with @immutable - Update SyncListItem parameters and modifiers for Compose idioms - Remove obsolete XML layout and unused ic_arrow_back.xml drawable - Update SyncStatusFragment to use ComposeView with DisposeOnViewTreeLifecycleDestroyed - Add unit and Compose UI tests for SyncStatusViewModel, SyncStatusScreen, and update SyncStatusFragmentTest
shobhitagarwal1612
force-pushed
the
sync
branch
from
September 8, 2026 12:11
acc9f1b to
3f8d5b0
Compare
shobhitagarwal1612
requested a deployment
to
e2e-approval
September 8, 2026 15:07 — with
GitHub Actions
Waiting
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3923 +/- ##
============================================
- Coverage 69.79% 69.70% -0.09%
+ Complexity 1987 1984 -3
============================================
Files 415 417 +2
Lines 11380 11426 +46
Branches 1486 1488 +2
============================================
+ Hits 7943 7965 +22
- Misses 2670 2692 +22
- Partials 767 769 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1795
Migrates
SyncStatusFragmentfrom the legacy XML layout to pure Jetpack Compose.sync_status_frag.xmlwithSyncStatusScreencomposableSyncStatusViewModelfromLiveDatatoStateFlow<SyncStatusState>SyncStatusFragmentto a thinComposeViewwrappersync_status_frag.xmlandic_arrow_back.xml@andreia-ferreira PTAL?