Skip to content

Migrate Offline Area Screens to Compose - #3915

Open
shobhitagarwal1612 wants to merge 5 commits into
masterfrom
offline-selector
Open

Migrate Offline Area Screens to Compose#3915
shobhitagarwal1612 wants to merge 5 commits into
masterfrom
offline-selector

refactor: address review comments on offline areas Compose migration

2bcc0cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 4, 2026 in 1s

69.75% (+0.28%) compared to 870e27b

View this Pull Request on Codecov

69.75% (+0.28%) compared to 870e27b

Details

Codecov Report

❌ Patch coverage is 80.32200% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.75%. Comparing base (870e27b) to head (2bcc0cc).

Files with missing lines Patch % Lines
...offlineareas/selector/OfflineAreaSelectorScreen.kt 78.20% 24 Missing and 10 partials ⚠️
...form/android/ui/offlineareas/OfflineAreasScreen.kt 79.66% 14 Missing and 10 partials ⚠️
.../ui/offlineareas/viewer/OfflineAreaViewerScreen.kt 75.82% 17 Missing and 5 partials ⚠️
...i/offlineareas/viewer/OfflineAreaViewerFragment.kt 52.17% 9 Missing and 2 partials ⚠️
.../offlineareas/viewer/OfflineAreaViewerViewModel.kt 78.57% 4 Missing and 2 partials ⚠️
...flineareas/selector/OfflineAreaSelectorFragment.kt 76.47% 2 Missing and 2 partials ⚠️
...rm/android/ui/offlineareas/OfflineAreasFragment.kt 86.36% 0 Missing and 3 partials ⚠️
...monMain/kotlin/org/groundplatform/ui/theme/Size.kt 0.00% 3 Missing ⚠️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 95.74% 0 Missing and 2 partials ⚠️
...rg/groundplatform/android/ui/components/Toolbar.kt 94.73% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3915      +/-   ##
============================================
+ Coverage     69.46%   69.75%   +0.28%     
- Complexity     1965     1984      +19     
============================================
  Files           412      415       +3     
  Lines         11018    11361     +343     
  Branches       1453     1483      +30     
============================================
+ Hits           7654     7925     +271     
- Misses         2613     2670      +57     
- Partials        751      766      +15     
Files with missing lines Coverage Δ
...tform/android/ui/offlineareas/OfflineAreasState.kt 100.00% <100.00%> (ø)
...m/android/ui/offlineareas/OfflineAreasViewModel.kt 100.00% <100.00%> (+16.66%) ⬆️
.../offlineareas/selector/OfflineAreaSelectorEvent.kt 100.00% <ø> (ø)
.../offlineareas/selector/OfflineAreaSelectorState.kt 100.00% <100.00%> (ø)
...d/ui/offlineareas/viewer/OfflineAreaViewerState.kt 100.00% <100.00%> (ø)
...rg/groundplatform/android/ui/components/Toolbar.kt 94.73% <94.73%> (+7.23%) ⬆️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 94.11% <95.74%> (+5.69%) ⬆️
...rm/android/ui/offlineareas/OfflineAreasFragment.kt 88.46% <86.36%> (+1.50%) ⬆️
...monMain/kotlin/org/groundplatform/ui/theme/Size.kt 0.00% <0.00%> (ø)
...flineareas/selector/OfflineAreaSelectorFragment.kt 71.79% <76.47%> (+0.36%) ⬆️
... and 5 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.