Skip to content

Bundle commonmark in the Eclipse plugin. - #1511

Merged
copybara-service[bot] merged 1 commit into
masterfrom
test_1009611288
Oct 29, 2026
Merged

copybara-service[bot] merged 1 commit into
masterfrom
test_1009611288

Conversation

@copybara-service

@copybara-service copybara-service Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Bundle commonmark in the Eclipse plugin.

Markdown Javadoc formatting made google-java-format depend on commonmark and commonmark-ext-gfm-tables, but the Eclipse plugin only bundles the jars it lists explicitly, and those weren't added. Since 1.36.0, formatting in Eclipse has failed with NoClassDefFoundError: org/commonmark/parser/Parser.

This also updates the plugin's stale version from 1.31.0 to 1.37.0. Regular CI builds the plugin against the google-java-format release matching that version, and 1.31.0 predates the commonmark dependency, so its jars weren't available to bundle. Release builds already set the version to the one being released.

Fixes #1428

@copybara-service
copybara-service Bot force-pushed the test_1009611288 branch 2 times, most recently from 77ad6e3 to b971b68 Compare October 29, 2026 13:59
Markdown Javadoc formatting made `google-java-format` depend on `commonmark` and `commonmark-ext-gfm-tables`, but the Eclipse plugin only bundles the jars it lists explicitly, and those weren't added. Since 1.36.0, formatting in Eclipse has failed with `NoClassDefFoundError: org/commonmark/parser/Parser`.

This also updates the plugin's stale version from 1.31.0 to 1.37.0. Regular CI builds the plugin against the `google-java-format` release matching that version, and 1.31.0 predates the commonmark dependency, so its jars weren't available to bundle. Release builds already set the version to the one being released.

Fixes #1428

PiperOrigin-RevId: 1009660207
@copybara-service
copybara-service Bot merged commit 044bbe6 into master Oct 29, 2026
16 checks passed
@copybara-service
copybara-service Bot deleted the test_1009611288 branch October 29, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible issue with Eclipse plugin

1 participant