Repository navigation
Bundle commonmark in the Eclipse plugin. - #1511
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1009611288
branch
2 times, most recently
from
October 29, 2026 13:59
77ad6e3 to
b971b68
Compare
Markdown Javadoc formatting made `google-java-format` depend on `commonmark` and `commonmark-ext-gfm-tables`, but the Eclipse plugin only bundles the jars it lists explicitly, and those weren't added. Since 1.36.0, formatting in Eclipse has failed with `NoClassDefFoundError: org/commonmark/parser/Parser`. This also updates the plugin's stale version from 1.31.0 to 1.37.0. Regular CI builds the plugin against the `google-java-format` release matching that version, and 1.31.0 predates the commonmark dependency, so its jars weren't available to bundle. Release builds already set the version to the one being released. Fixes #1428 PiperOrigin-RevId: 1009660207
copybara-service
Bot
force-pushed
the
test_1009611288
branch
from
October 29, 2026 14:05
b971b68 to
044bbe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle commonmark in the Eclipse plugin.
Markdown Javadoc formatting made
google-java-formatdepend oncommonmarkandcommonmark-ext-gfm-tables, but the Eclipse plugin only bundles the jars it lists explicitly, and those weren't added. Since 1.36.0, formatting in Eclipse has failed withNoClassDefFoundError: org/commonmark/parser/Parser.This also updates the plugin's stale version from 1.31.0 to 1.37.0. Regular CI builds the plugin against the
google-java-formatrelease matching that version, and 1.31.0 predates the commonmark dependency, so its jars weren't available to bundle. Release builds already set the version to the one being released.Fixes #1428