Repository navigation
Reject negated Gin references instead of silently dropping the minus - #226
Draft
srijan2607 wants to merge 1 commit into
Draft
srijan2607 wants to merge 1 commit into
srijan2607 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gin currently accepts
-%amountand-@amount()but silently drops the minus. For example, bindingcapture.value = -%positivewhenpositive = 7injects7.Raise
SyntaxErrorwhen a consumed minus is not followed by a literal token, rather than falling through to reference parsing. This rejects unsupported negation; it does not add expression evaluation. Negative numeric literals keep working.Tests cover macros and configurable references, whitespace, nested containers, and negative numeric literals. All 13 parser tests pass on Python 3.11 and 3.13. The broader native core runs have the same two missing-fixture-module errors on base and patch; the optional TensorFlow/PyTorch installation-based test matrix was not run.