Repository navigation
fix: isolate selector trees when copying maps - #223
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying a
SelectorMapcurrently shares the nested selector tree while copying its value dictionary. Addingtwo.nameto a copy containingone.namemakes the original'sget_all_matches('name')raiseKeyError; removing an entry from the copy also removes it from the original's partial matches.Deep-copy the internal tree while retaining the shallow copy of stored values. Regression tests cover both copy entry points, changes in both directions, deletion, and preservation of value identity.
Validation: new regression cases fail before the change. Afterward, 21 selector/parser/resource tests and 2 subtests pass. The 116 configuration tests pass with 1 skip when run as
__main__, withTEST_SRCDIRset and the existingtests/testdatafixture directory added togin.testdata.__path__. TensorFlow/PyTorch integration suites were not run.git diff --checkpasses.