fix(馃挜): detach swapchains before device destroy - #84
Open
wcandillon wants to merge 1 commit into
Open
Conversation
|
馃憢 Thanks for your contribution! Your PR has been imported to Gerrit. |
wcandillon
force-pushed
the
detach-before-device-destroy
branch
from
September 10, 2026 12:25
061ee78 to
72a406f
Compare
Member
|
Something weird happened causing your commit to pick up all the submodules (which also caused it to fail to re-import to Gerrit). Could you reset those? |
Change-Id: I3c0b35c29698bc9f74db41b210e2194c019fa15f
wcandillon
force-pushed
the
detach-before-device-destroy
branch
from
September 10, 2026 18:12
72a406f to
8d98997
Compare
Contributor
Author
|
@kainino0x yes sorry about that 馃檹 And a big Thank You for your support on these patches 鉂わ笍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was reported by a RN WebGPU user who is using three.js: when Three.js destroys the device it created, we get the following crash (Vulkan only, Metal is fine):
We are able to reproduce it nicely. This didn't come up before because because in our own examples we provide the device ourselves so three.js won't destroy it.