Skip to content

Avoid undefined behaviour conversions from unaligned char* to int* #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gchatelet merged 1 commit into from
Jun 24, 2026
+7 −6
Merged

Avoid undefined behaviour conversions from unaligned char* to int* #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/impl_x86__base_implementation.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,16 +238,17 @@ static bool HasTmmOsXSave(uint32_t xcr0_eax) {
////////////////////////////////////////////////////////////////////////////////

static void SetVendor(const Leaf leaf, char* const vendor) {
*(uint32_t*)(vendor) = leaf.ebx;
*(uint32_t*)(vendor + 4) = leaf.edx;
*(uint32_t*)(vendor + 8) = leaf.ecx;
memcpy(vendor, &leaf.ebx, 4);
memcpy(vendor + 4, &leaf.edx, 4);
memcpy(vendor + 8, &leaf.ecx, 4);
vendor[12] = '\0';
}

static int IsVendor(const Leaf leaf, const char* const name) {
const uint32_t ebx = *(const uint32_t*)(name);
const uint32_t edx = *(const uint32_t*)(name + 4);
const uint32_t ecx = *(const uint32_t*)(name + 8);
uint32_t ebx, edx, ecx;
memcpy(&ebx, name, 4);
memcpy(&edx, name + 4, 4);
memcpy(&ecx, name + 8, 4);
return leaf.ebx == ebx && leaf.ecx == ecx && leaf.edx == edx;
}

Expand Down
Loading