Skip to content

test(mcp): let the emulator win32 branch be exercised from any host #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basil-k-aji-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

test(mcp): let the emulator win32 branch be exercised from any host #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/unit/mcp/test_device_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
def test_ensure_emulator_uses_windows_creation_flags(monkeypatch) -> None:
popen = MagicMock()
monkeypatch.setattr(device_utils.sys, "platform", "win32")
# CREATE_NEW_PROCESS_GROUP and DETACHED_PROCESS exist in subprocess only on
# Windows, so reaching the win32 branch from a POSIX host needs them stubbed
# with their documented values. Without them the branch raises
# AttributeError, ensure_emulator's `except Exception: return False`
# swallows it, and this test can only pass on a Windows runner.
monkeypatch.setattr(
device_utils.subprocess, "CREATE_NEW_PROCESS_GROUP", 0x00000200, raising=False
)
monkeypatch.setattr(device_utils.subprocess, "DETACHED_PROCESS", 0x00000008, raising=False)
monkeypatch.setattr(device_utils, "is_emulator_running", lambda _adb: False)
monkeypatch.setattr(device_utils.os.path, "exists", lambda _path: True)
monkeypatch.setattr(device_utils.subprocess, "Popen", popen)
Expand Down