Conversation
… source
DesktopNotifier.notify() built the macOS and Windows toast commands by
f-string-interpolating the notification title/body directly into an
AppleScript `display notification "..."` literal and a PowerShell
CreateTextNode("...") literal, then ran them via osascript/powershell
with no escaping. A quote or newline in that text lets it break out of
the string literal and run as its own AppleScript/PowerShell statement.
The notified text (task goal + task result) can contain content the
agent observed while automating an app or web page, so an attacker who
controls what's on the screen during a task controls this text. Desktop
notifications are enabled by default (no opt-in env var required), so
this reaches every default install on macOS and Windows.
Fix: pass the title/body through the environment instead of
interpolating them into the script source, and read them back with
`system attribute` (AppleScript) / `$env:` (PowerShell). The script
text itself is now a fixed constant that never varies with input.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
carfeii
deleted the
fix/desktop-notifier-applescript-powershell-injection
branch
September 21, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.