Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes LLM failure classification when provider SDKs wrap transport-level
connection failures.
During an end-to-end Artemis Flash test against an OpenAI-compatible LM Studio
endpoint, Artemis recorded:
provider: openaierror: "Connection error."max_retries: 2The retry count showed that the exception was being classified as
UNKNOWN,even though the underlying failure was a connection error.
Provider SDKs such as OpenAI commonly wrap transport exceptions in types like
APIConnectionError, so checking only the outer exception loses the actualfailure category.
This change:
__cause__/__context__safely;CONNECTION;Why this matters
A wrapped connection error currently receives the
UNKNOWNretry policy(2 attempts) instead of the
CONNECTIONretry policy (3 attempts), which canprematurely pause an otherwise recoverable task.
Validation
Validated on Windows with Artemis Flash using:
qwen/qwen3.8-27bEnd-to-end functional test completed successfully:
The original failing trace recorded:
{ "error": "Connection error.", "attempt": 1, "max_retries": 2, "provider": "openai" }