fix(client): restrict redirects to same-origin reads - #120
Open
Chris0Jeky wants to merge 3 commits into
Open
Chris0Jeky wants to merge 3 commits into
Chris0Jeky wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep bearer tokens and custom headers from following redirects to another origin. Same-origin GET/HEAD redirects still work; redirected POSTs are rejected without replay. Clients behind redirecting gateways must use the final trusted endpoint.
26 client tests pass on Linux Python 3.10/3.12/3.13 and Windows Python 3.12/3.13. Full locked tests remain red (base 92 failures, candidate 93); the extra timing failure also reproduced on unchanged base. Both have 11 lint findings; format and core types pass.
Google security directed this fix to the project maintainers.