fix(client): close HTTP error response bodies - #116
Open
Chris0Jeky wants to merge 1 commit into
Open
Chris0Jeky wants to merge 1 commit into
Chris0Jeky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP error responses stayed open after the client decoded their bodies. This closes them even when reading fails, while preserving the mapped exception, status and cause.
The 24 client tests pass on Windows and Linux. The new closure assertions fail without the fix.
Full locked tests still have the same 92 failing IDs as base; repository lint has the same 11 findings. Formatting and protected-core type checks pass.
Test:
PYTHONPATH=packages/artemis-client/src python -m unittest discover -s packages/artemis-client/tests -v