fix(console): treat string "false" as not stop-all on /api/stop - #111
Open
Faisal01011 wants to merge 2 commits into
Open
Faisal01011 wants to merge 2 commits into
Faisal01011 wants to merge 2 commits into
Conversation
JSON body values like "false" were coerced with bool(), which is True for any non-empty string, so a scoped stop cancelled every task. Fixes google#36
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/stopoverwrote the query-paramallflag withbool(body["all"]).Python treats any non-empty string as true, so
{"all": "false"}cancelledevery running task.
Parse JSON/query-like string booleans explicitly and keep session-scoped stops scoped.
Fixes #36
Test plan
coerce_booland/api/stopbody/query combinationsmake test/make lint/make typecheck