Conversation
Some Android versions store the helper as pkg/pkg.Class instead of pkg/.Class, so helper status, enable, revive, and uninstall missed it. Fixes google#109 Signed-off-by: Ayo Omotayo <ayonifeoluwa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #109.
artemis helper statusreportedService enabled: nowhen the helper was actually enabled and bound. Some Android versions (observed on Android 11) store the accessibility component in flattened form (com.artemis.helper/com.artemis.helper.ArtemisAccessibilityService) instead of the short form Artemis writes (com.artemis.helper/.ArtemisAccessibilityService).Status, enable, revive, and uninstall compared the settings list with exact string equality, so the flattened entry was treated as a different service.
This change normalizes both ComponentName notations (
pkg/.Classandpkg/pkg.Class) before comparing, so the helper is recognized whichever form the platform stored.Test plan
uv run pytest tests/unit/runtime/test_helper_manager.py— 48 passed, including:settings putis flattened on read-backuv run ruff check/ruff format --checkon the two changed files — cleanartemis helper statuson an Android 11 device wheresettings get secure enabled_accessibility_servicesshows the flattened component